This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Use typed SelectProps #2467
Merged
Use typed SelectProps #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubis741
requested review from
lorgan3,
KristofColpaert,
BeirlaenAaron,
driesd,
eniskraasniqi1,
farazatarodi,
jelledc,
JorenSaeyTL,
lowiebenoot and
stefaandevylder
stefaandevylder
previously approved these changes
Nov 28, 2022
lorgan3
reviewed
Nov 28, 2022
👍
Minor is ok for me |
farazatarodi
previously approved these changes
Nov 28, 2022
qubis741
dismissed stale reviews from farazatarodi and stefaandevylder
via
cfd8385
lorgan3
previously approved these changes
Nov 29, 2022
stefaandevylder
previously approved these changes
Nov 29, 2022
| @@ -57,8 +56,9 @@ export const DropdownWithUpsell: ComponentStory<typeof MarketingMenuItem> = (arg | |||
| }, | |||
| [args], | |||
| ); | |||
| const handleChange = (option: Option) => console.log(option); | |||
There was a problem hiding this comment.
maybe an alert is a better option
There was a problem hiding this comment.
I dont think so, it is rather invasive and we dont do it anywhere else
farazatarodi
previously approved these changes
Nov 29, 2022
qubis741
dismissed stale reviews from farazatarodi, stefaandevylder, and lorgan3
via
2f44dce
lorgan3
approved these changes
Nov 29, 2022
stefaandevylder
approved these changes
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[17.2.0] - 2022-11-29
Changed
Typescript: All components and their props are typescriptManual Check
N/A, I have connected it to
core, all fixed is here: https://github.com/teamleadercrm/core/pull/29569 and its only type changesSince now everything is in TS, I think we should start mentioning it in
CHANGELOG.MD, but I am not sure if to release as major or minor version. Your thoughts?